XmlStreamWriter: make single arg methods explicit. Drop unused methods.

diff --git a/src/core/xmlstreamwriter.cc b/src/core/xmlstreamwriter.cc
index 70c59fc214c83c7b0f60cba0cddfb411fd7e5091..fa74d7c31af8471e25d2f19ea438b41a07bf1af3 100644 (file)
--- a/src/core/xmlstreamwriter.cc
+++ b/src/core/xmlstreamwriter.cc
@@ -88,14 +88,6 @@ void XmlStreamWriter::writeStartDocument()
   writeProcessingInstruction(QStringLiteral("xml version=\"1.0\" encoding=\"UTF-8\""));
 }
 
-// Dont emit the attribute if there's nothing interesting in it.
-void XmlStreamWriter::writeOptionalAttribute(const QString& qualifiedName, const QString& value)
-{
-  if (!value.isEmpty()) {
-    QXmlStreamWriter::writeAttribute(qualifiedName, value);
-  }
-}
-
 // Dont emit the element if there's nothing interesting in it.
 void XmlStreamWriter::writeOptionalTextElement(const QString& qualifiedName, const QString& text)
 {

diff --git a/src/core/xmlstreamwriter.h b/src/core/xmlstreamwriter.h
index 829a421cf5818b32cca380455ed82454b1e46c6d..77290cca480970338c8bbd8255d04007f5ef3628 100644 (file)
--- a/src/core/xmlstreamwriter.h
+++ b/src/core/xmlstreamwriter.h
@@ -49,11 +49,10 @@ protected:
 class XmlStreamWriter : public QXmlStreamWriter
 {
 public:
-  XmlStreamWriter(QString* string);
-  XmlStreamWriter(QFile* f);
+  explicit XmlStreamWriter(QString* string);
+  explicit XmlStreamWriter(QFile* f);
 
-  void writeStartDocument(void);
-  void writeOptionalAttribute(const QString& qualifiedName, const QString& value);
+  void writeStartDocument();
   void writeOptionalTextElement(const QString& qualifiedName, const QString& text);
 };